Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CST-based fixers for C405 and C409 #9821

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Remove CST-based fixers for C405 and C409 #9821

merged 1 commit into from
Feb 5, 2024

Conversation

charliermarsh
Copy link
Member

No description provided.

@charliermarsh charliermarsh added the fixes Related to suggested fixes for violations label Feb 5, 2024
@charliermarsh charliermarsh marked this pull request as ready for review February 5, 2024 02:04
@charliermarsh charliermarsh enabled auto-merge (squash) February 5, 2024 02:14
@charliermarsh charliermarsh merged commit a6bc4b2 into main Feb 5, 2024
16 checks passed
@charliermarsh charliermarsh deleted the charlie/lcst2 branch February 5, 2024 02:17
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 5, 2024

CodSpeed Performance Report

Merging #9821 will improve performances by 8.42%

Comparing charlie/lcst2 (cb00129) with main (c5fa0cc)

Summary

⚡ 2 improvements
✅ 28 untouched benchmarks

Benchmarks breakdown

Benchmark main charlie/lcst2 Change
⚡ linter/all-rules[unicode/pypinyin.py] 11.6 ms 10.7 ms +8.42%
⚡ linter/all-with-preview-rules[unicode/pypinyin.py] 12.6 ms 11.6 ms +8.38%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2024

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check encountered linter errors. (no lint changes; 1 project error)

sphinx-doc/sphinx (error) 

ruff failed
  Cause: Selection of unstable rules without the `--preview` flag is not allowed. Enable preview or remove selection of:
	- FURB113
	- FURB131
	- FURB132

Linter (preview)

✅ ecosystem check detected no linter changes.

@miccal miccal mentioned this pull request Feb 6, 2024
Merged
@bswck bswck mentioned this pull request Mar 15, 2024
Merged
@dhruvmanila dhruvmanila mentioned this pull request Apr 15, 2024
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fixes Related to suggested fixes for violations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@charliermarsh